[macports-ports] branch master updated: smlnj: fix https://trac.macports.org/ticket/47232

[Ryan Schmidt]

On Nov 16, 2017, at 12:41, Toby Peterson wrote:

> Already replied to l2dy's comment on the commit -

Sorry, I didn't realize a comment had been made on the commit in the GitHub web interface. I don't receive notifications for those, I guess.

> it's a meaningless change. Also it was four minutes after the previous, so I figured nobody got the first revision 0... it's fine either way.

The buildbot got the previous commit, and our packages server distributes the binaries created from it. If you're going to make a change that changes installed files, please increase the revision so that users receive that change.


On Thu, Nov 16, 2017 at 2:09 AM, Ryan Schmidt wrote:

> On Nov 15, 2017, at 00:24, Toby Peterson wrote:
> 
> > tobypeterson pushed a commit to branch master
> > in repository macports-ports.
> >
> >
> > https://github.com/macports/macports-ports/commit/01c37e8ae32a00f0b6edd197c4eb9a85f5e4f5bd
> >
> > The following commit(s) were added to refs/heads/master by this push:
> >
> >      new 01c37e8  smlnj: fix https://trac.macports.org/ticket/47232
> >
> > 01c37e8 is described below
> >
> >
> > commit 01c37e8ae32a00f0b6edd197c4eb9a85f5e4f5bd
> >
> > Author: Toby Peterson <toby at macports.org>
> > AuthorDate: Tue Nov 14 22:24:36 2017 -0800
> >
> >
> >     smlnj: fix https://trac.macports.org/ticket/47232
> 
> 
> > --- a/lang/smlnj/Portfile
> > +++ b/lang/smlnj/Portfile
> > @@ -101,7 +101,7 @@ destroot {
> >      file copy ${worksrcpath}/bin ${destroot}${smlnj_home}
> >      file copy ${worksrcpath}/lib ${destroot}${smlnj_home}
> >
> > -    xinstall -m 555 ${filespath}/sml.sh ${destroot}${prefix}/bin/sml
> > +    xinstall -m 755 ${filespath}/sml.sh ${destroot}${prefix}/bin/sml
> 
> This changes the files installed by the port, so you must increase the revision.