[macports-ports] branch master updated: fix apache2 (2.4.x) loading issue

[Ryan Schmidt]

On Nov 3, 2017, at 13:23, Marius Schamschula wrote:

> Marius Schamschula (Schamschula) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/11269f88923f112e9d87fa2b42f186b0c765f9a6
> 
> The following commit(s) were added to refs/heads/master by this push:
> 
>      new 11269f8  fix apache2 (2.4.x) loading issue
> 
> 11269f8 is described below
> 
> 
> commit 11269f88923f112e9d87fa2b42f186b0c765f9a6
> 
> Author: Marius Schamschula <Schamschula at users.noreply.github.com>
> AuthorDate: Fri Nov 3 13:23:32 2017 -0500
> 
> 
>     fix apache2 (2.4.x) loading issue
> 
> ---
>  lang/php/files/mod_php.conf.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff --git a/lang/php/files/mod_php.conf.in b/lang/php/files/mod_php.conf.in
> index 10c112e..57d30bc 100644
> --- a/lang/php/files/mod_php.conf.in
> +++ b/lang/php/files/mod_php.conf.in
> @@ -1,4 +1,4 @@
> -<IfModule mod_php at MAJOR@.c>
> +<IfModule php at MAJOR@_module>


The php*-apache2handler subports install this file, so you must increase those subports' revisions to cause this change to be seen by users.

But are you sure this change is correct for all versions of PHP? I find it unlikely that this file has always been incorrect. "<IfModule mod_php5.c>" is still what's shown at:

http://php.net/manual/en/configuration.changes.php

It seems more likely that it used to be correct, and then some new version of PHP changed the module name; if that's so, then the port needs to use the old way for old versions and the new way for new versions, and the revisions of all the php*-apache2handler subports need to be increased in case any user built the port while the portfile was wrong.

I'm trying to find a citation that shows when the module name changed...