[macports-ports] branch master updated: libpsl: new port

[Ryan Schmidt]

On Nov 19, 2017, at 17:37, David B. Evans wrote:

> David B. Evans (dbevans) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/46f404371eac6db23120c395c8cef21e438b97f7
> 
> The following commit(s) were added to refs/heads/master by this push:
> 
>      new 46f4043  libpsl: new port
> 
> 46f4043 is described below
> 
> 
> commit 46f404371eac6db23120c395c8cef21e438b97f7
> 
> Author: David B. Evans <devans at macports.org>
> AuthorDate: Sun Nov 19 15:37:41 2017 -0800
> 
> 
>     libpsl: new port
> 
>     
> 
>     A C library and utility to handle the Public Suffix List.


> +# latest public suffix list data is referenced as a git submodule
> +# in the libpsl git repo but not included in the libpsl tarball itself
> +# download separately to enable generation of built-in psl data
> +
> +set psl_data_dir        ${workpath}
> +set psl_data_commit     e8c69a676d76560d9239b98f0fa802efd3986e19
> +set psl_data_archive    ${psl_data_commit}.zip
> +set psl_data_url        https://github.com/publicsuffix/list/archive
> +
> +post-extract {
> +    curl fetch ${psl_data_url}/${psl_data_archive} ${psl_data_dir}/${psl_data_archive}
> +    system "/usr/bin/unzip -d ${worksrcpath} ${psl_data_dir}/${psl_data_archive}"
> +    delete ${worksrcpath}/list
> +    move ${worksrcpath}/list-${psl_data_commit} ${worksrcpath}/list
> +}

Could you add this to $distfiles, instead of fetching it manually? That way, the fetch will occur in the fetch phase, where it belongs, and it could be mirrored, and the user wouldn't need to download it every time.

You should also use the .tar.gz version instead of the .zip version because it is smaller, and that will make it easier (i.e. possible) for MacPorts to extract it for you at the same time that it extracts the port's main distfile.