[macports-ports] 02/02: ghostscript 9.22: rev bump dependents

Ryan Schmidt ryandesign at macports.org
Sun Oct 8 00:15:23 UTC 2017


> On Oct 6, 2017, at 20:34, Marius Schamschula <mps at macports.org> wrote:
> 
> Marius Schamschula (Schamschula) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/fe0730636309d31fbee348f1384702ba3c90b35c
> 
> commit fe0730636309d31fbee348f1384702ba3c90b35c
> 
> Author: Marius Schamschula <mps at macports.org>
> AuthorDate: Fri Oct 6 20:34:48 2017 -0500
> 
> 
>     ghostscript 9.22: rev bump dependents
> 
>     
> 
>     fix whitespace and add modeline, where missing


If a port already conforms to the modeline but doesn't have one, you can add it while doing other changes; other minor changes, like obfuscating email addresses or adding GitHub handles to maintainers are fine too.

But it would be best in the future to make whitespace changes separately from functional changes, so that those diffs, which can get large and can affect every line of a Portfile, can be safely ignored by reviewers. Such a commit is also a good time to add or correct the modeline.


> -- a/science/gmt5/Portfile
> +++ b/science/gmt5/Portfile
> @@ -5,9 +5,11 @@ PortGroup           cmake 1.0
>  
>  name                gmt5
>  version             5.4.2
> +revision            1
>  categories          science
>  platforms           darwin
> -maintainers         takeshi
> +maintainers         eprofs.de:florian \
> +                    takeshi
>  license             GPL-3
>  description         The Generic Mapping Tools
>  long_description GMT is an open source collection of ~120 tools \
> @@ -28,6 +30,10 @@ master_sites        ftp://ftp.soest.hawaii.edu/gmt          \
>  use_xz              yes
>  distname            gmt-${version}
>  distfiles           ${distname}-src${extract.suffix}
> +
> +# stealth update 
> +dist_subdir         ${name}/${version}_1
> +
>  checksums           rmd160  ed90b3b46aeb98b7d5ed9bb0c68fbf7ebf7df929 \
>                      sha256  ddcd63094aeda5a60f541626ed7ab4a78538d52dea24ba915f168e4606e587f5
>  

This doesn't look intentional. It re-adds Florain as maintainer (you deliberately removed him in https://github.com/macports/macports-ports/commit/7d2e2673c27b3cbbf9266dd1a4e49f77682ef33f) and changes the dist_subdir even though the checksums were not changed, so there wasn't a stealth update.





More information about the macports-dev mailing list