[macports-ports] branch master updated: Multiple ports: add missing required variables

[Ryan Schmidt]

On Oct 13, 2017, at 06:07, Zero King wrote:

> On Thu, Oct 05, 2017 at 10:29:52PM -0500, Ryan Schmidt wrote:
>> 
>> On Oct 5, 2017, at 17:49, Kurt Hindenburg wrote:
>> 
>>> Kurt Hindenburg (kurthindenburg) pushed a commit to branch master
>>> in repository macports-ports.
>>> 
>>> 
>>> https://github.com/macports/macports-ports/commit/e8d12170f2e412c25e53a770acd58cb2f40e27ea
>>> 
>>> The following commit(s) were added to refs/heads/master by this push:
>>> 
>>>     new e8d1217  Multiple ports: add missing required variables
>> 
>> 
>>> --- a/sysutils/detach/Portfile
>>> +++ b/sysutils/detach/Portfile
>>> @@ -11,6 +11,7 @@ long_description        The  command is a grungy little program for \
>>> 
>>> 			executing programs in the background, \
>>> 			without use of a control  terminal. \
>>> 			(In the style of most common daemon processes...)
>>> +homepage        https://www.macports.org
>>> master_sites    http://ftp.ntnu.no/old/pub/unix/utils/
>>> checksums       md5 843c6ff1590a56c1733c958a86cd8a93
>>> pre-configure   { reinplace "s|/usr/local|${destroot}${prefix}|g" ${worksrcpath}/Makefile
>> 
>> This is the only change here I'd disagree with. We should only use that homepage on software we developed. For software that doesn't have a web page, using the download location as the homepage is probably acceptable. It's also acceptable not to set a homepage in those cases, in my opinion. "port info" simply omits the homepage information in that case, and "port gohome" knows to display an error message, so nothing breaks if there is no homepage set.
> 
> Then you should "fix" the obsolete 1.0 PortGroup
> 
>> homepage        https://www.macports.org/

Yeah, I don't like that the obsolete portgroup does that either.