[macports-ports] 01/04: aften: An A/52 audio encoder

[Ryan Schmidt]

The fact that the cmake 1.1 portgroup uses build type "MacPorts", not "Release", is meant to be a feature, not a bug:

https://trac.macports.org/ticket/52699#comment:1

> • use CMAKE_BUILD_TYPE=MacPorts. Inspired by Debian's own build type, this allows us to specify all compiler settings via the well-known configure.* commands and exported via the environment. If one of CMake's predefined types is used the corresponding standard options will be *appended* to our options, which will override notably the optimisation options. Some parsing of configure.cppflags, configure.cflags and configure.cxxflags is done to ensure this works as expected, in lines 145-200 .



On Apr 6, 2018, at 07:18, Michael Dickens wrote:

> My primary reason for not moving to cmake 1.1 in the various GR & other ports I use is that it sets the default build type to "MacPorts", which has no real meaning & actually conflicts with some of my ports' cmake scripts & so I have to work around that (which isn't difficult; just takes time and testing). Otherwise I find that for my ports they seem to provide roughly the same outcome (same cmake commandline). If the default build type were "Release" I'd have no issue switching right now & it would simplify my ports that use cmake 1.0. - MLD
> 
> On Fri, Apr 6, 2018, at 3:52 AM, Ryan Schmidt wrote:
>> 
>> On Apr 6, 2018, at 02:48, Clemens Lang wrote:
>> 
>>> On 6 Apr, 2018, at 08:03, Ryan Schmidt wrote:
>>> 
>>>> jack conflicts with jack?
>>> 
>>> Thanks, remnant from my attempts to package jack and jack2 in separate ports.
>>> Fixed in 678e0100a4c07d55750e6dc667492dc26cdab208.
>>> 
>>>> On Apr 5, 2018, at 18:18, Clemens Lang wrote:
>>>>> +PortGroup           cmake 1.0
>>>> 
>>>>> +cmake.out_of_source yes
>>>> 
>>>> We should be using the cmake 1.1 portgroup for new ports, and moving old ports
>>>> that use cmake 1.0 to 1.1 as time permits. cmake 1.1 defaults to out-of-source
>>>> builds, and has other improvements over cmake 1.0.
>>> 
>>> I'm not convinced the changes in cmake 1.1 are actually an improvement over the
>>> state of the cmake 1.0 portgroup. What do you think the improvements are?
>> 
>> Well I don't know. It defaults to out-of-source builds adds options for 
>> configuring some values, both of which are good, and it has support for 
>> generators which I don't know anything about, and probably some other 
>> changes. Here's the ticket describing 1.1's creation:
>> 
>> https://trac.macports.org/ticket/52699
>>