[macports-ports] branch master updated: jack: Fix upgrade path from jack1

[Clemens Lang]

Hi,

----- On 7 Apr, 2018, at 09:50, Ryan Schmidt ryandesign at macports.org wrote:

>> +# deactivate hack added 2018-04-06
>> +pre-configure {
>> +    # When upgrading from jack1 to jack2, the build can fail outside of trace
>> +    # mode because waf puts the CPPFLAGS at the beginning of the compiler
>> +    # command line. This was fixed in waf 1.9.0, but jack2 ships waf 1.8.17.
>> +    #
>> +    # Instead of using the conflicts-build portgroup, use a deactivate hack to
>> +    # force-deactive the old version before building, which should solve the
>> +    # issue.
>> 
> 
> Why handle this port differently from other ports that have this problem (where
> we use "conflicts_build ${name}")?

That was my initial idea as well, but it requires user interaction, which is not
ideal for a port upgrade. I hope to get this fixed by upstream for the next update
so that this is a one-shot solution that can be removed again with the next new
version.

-- 
Clemens Lang