port version reports 2.4.2 when built from tag v2.4.3

[Enrico Maria Crisostomo]

Hi Joshua,

Thanks.  The port script was the correct one.  I think I re-configured and built v2.4.3 over a previous v2.4.2 build but I can't confirm.  I cleaned the HEAD and rebuilt and the result is as expected.

I noticed in the documentation that "2.2.3 git install" instructs to make distclean after the build, while "2.2.4 Install multiple MacPorts Copies" does not.  Perhaps amending the documentation may help others not to stumble on this one, even if the blame is to be attributed to the user in this case.  I'll send a PR for that one.

Cheers,
-- 
Enrico

> On 11 Apr 2018, at 14:17, Joshua Root <jmr at macports.org> wrote:
> 
> On 2018-4-11 18:52 , Enrico Maria Crisostomo wrote:
>> Hi,
>> 
>> I've just created a new installation of macports-base from tag v2.4.3 following the instructions in the documentation (basically git checkout v2.4.3, ./configure ..., make and make install) and I've just noticed that `port` reports 2.4.2:
>> 
>>    % which port
>>    /opt/macports-2.4.3/bin/port
>>    % port version
>>    Version: 2.4.2
>> 
>> I built from:
>> 
>>    % git rev-parse HEAD
>>    a393413460aae5ac9749b994681381087089cdb5
>> 
>> which appears to be the correct v2.4.3:
>> 
>>    * commit a393413460aae5ac9749b994681381087089cdb5 (HEAD, tag: v2.4.3, upstream/release-2.4)
>>    | Author: Joshua Root <jmr at macports.org>
>>    | Date:   Wed Apr 11 10:23:40 2018 +1000
>>    |
>>    |     Bump branch version to 2.4.3
>> 
>> Am I missing something obvious or it this a typo?
> 
> I'm not sure how that happened for you. Browsing the tag on GitHub, it
> says 2.4.3 in the appropriate places.
> 
> <https://github.com/macports/macports-base/blob/v2.4.3/config/macports_version>
> <https://github.com/macports/macports-base/blob/v2.4.3/configure#L2790>
> 
> Are you sure your shell didn't cache the location of port? Check with
> 'type port'. (Using 'which' tells you where it would be found if you
> cleared the cache.)
> 
> - Josh