port version reports 2.4.2 when built from tag v2.4.3

[Enrico Maria Crisostomo]

Well, I replicated it:

  * Clean the repo (e.g.: git clean -xfd)
  * git checkout v2.4.2
  * build and install 2.4.2:

      $ export PATH=/bin:/sbin:/usr/bin:/usr/sbin
      $ MP_PREFIX=/opt/macports-2.4.2
      $ ./configure --prefix=$MP_PREFIX --with-applications-dir=$MP_PREFIX/Applications
      $ make
      $ sudo make install

  * open new terminal
  * git checkout v2.4.3
  * configure 2.4.3:

      $ export PATH=/bin:/sbin:/usr/bin:/usr/sbin
      $ MP_PREFIX=/opt/macports-2.4.3
      $ ./configure --prefix=$MP_PREFIX --with-applications-dir=$MP_PREFIX/Applications

  * At this point src/macports1.0/macports_autoconf.tcl correctly contains `variable macports_version "2.4.3"`
  * build and install 2.4.3:

      $ make
      $ sudo make install

  * At this point /opt/macports-2.4.3/libexec/macports/lib/macports1.0/macports_autoconf.tcl correctly contains `variable macports_version "2.4.3"`.
  * But port reports 2.4.2:

      % echo path
      /opt/macports-2.4.3/bin:/opt/macports-2.4.3/sbin:/bin:/usr/bin:/usr/ucb:/usr/local/bin
      % type port
      port is /opt/macports-2.4.3/bin/port
      % port version
      Version: 2.4.2

If I clean the repo between the builds, the problem does not happen.

Cheers,
-- 
Enrico

> On 11 Apr 2018, at 15:32, Joshua Root <jmr at macports.org> wrote:
> 
> On 2018-4-11 23:27 , Enrico Maria Crisostomo wrote:
>> Thanks Rainer,
>> 
>> I can't check it but as I said in my previous mail I think I had forgotten to run `make distclean` when I previously built `v2.4.2`.  And now I see that the `macports_autoconf.tcl` file you cite is an Autoconf config file.  Why this happen now makes sense.
> 
> As Rainer said, running configure is supposed to update that file (and
> in my experience it does).
> 
> - Josh