Agility
Chris Jones
jonesc at hep.phy.cam.ac.uk
Wed Apr 25 18:17:57 UTC 2018
> On 25 Apr 2018, at 7:13 pm, Perry E. Metzger <pmetzger at macports.org> wrote:
>
> On Wed, 25 Apr 2018 18:48:33 +0200 Mojca Miklavec
> <mojca at macports.org> wrote:
>> I admit that I do find value in WIP PRs from time to time. Like ...
>> someone submitting an update to a library that needs coordinated
>> update with dependent ports that need to be tested individually. But
>> there are plenty other examples. Trac can be used, but GitHub has
>> advantages.
>
> I think that if something is intended to be committed fairly soon
> (say within a week or two), and it just needs a little polish, a WIP
> PR makes sense. You're not really saying "this isn't feature
> complete", you're saying "I need some serious review before we
> proceed on this and I'm expecting we'll need changes."
>
> If it is something is a long term project, if it is
> going to take six months say, then this isn't really a Pull Request
> (which really means "this should be considered for merging now"), and
> really what is probably better is to set up a work branch in git and
> invite other people to assist in polishing it to the point where it
> can be pulled. A Trac ticket can then point at the branch and be used
> to help coordinate work.
I still disagree, and would prefer to do all of this in git. But thats just my opinion, and doing what you say also works (just not as conveniently in my view).
>
>> Trac is quite ok for bug reports, but much less suitable for
>> (nearly) ready patches. GitHub on the other hand has drawbacks when
>> the number of issues grows.
>
> Indeed. Which is why I think using git's branch facility is the right
> tool, and not GitHub as such.
>
> Perry
> --
> Perry E. Metzger pmetzger at macports.org
More information about the macports-dev
mailing list