squash and merge, license documentation, "size" documentation

Jan Stary hans at stare.cz
Wed Aug 22 18:46:29 UTC 2018


On Aug 21 22:58:07, jmr at macports.org wrote:
> On 2018-8-18 06:06 , Clemens Lang wrote:
> > I think the idea of the size keyword is to start to use it to display
> > download progress bars for servers that do not send a Content-Length
> > HTTP header (or do not have an equivalent of such a header due to the
> > used protocol). This is currently not implemented.
> > 
> > 'port -v checksums' does generate the size field in newer versions of
> > MacPorts. Until such a version becomes the released default, I think
> > it's fine not to require adding it in PRs.
> 
> Not accepting PRs until they add it is certainly not a good approach.
> Recommend using it in all the docs, certainly. But don't put extra
> burden on both contributors and reviewers for the sake of an
> unimplemented minor feature.

https://github.com/macports/macports-ports/pull/2371
has been rotting for two weeks for exactly that.


More information about the macports-dev mailing list