leave revision 0 line in Portfile

Frank Schima mf2k at macports.org
Mon Dec 24 19:28:11 UTC 2018


Hi all,


I will follow the consensus and only request resetting revision to 0 and not removing the revision line. 


Cheers!
Frank

> On Dec 24, 2018, at 11:27 AM, Marius Schamschula <lists at schamschula.com> wrote:
> 
> +1
> 
> Along with adding the size checksum, where missing.
> 
>> On Dec 24, 2018, at 10:14 AM, Michael Dickens <michaelld at macports.org> wrote:
>> 
>> I'm in agreement here about keeping "revision 0" lines & will start implementing this in my ports as they get updates. - MLD
>> 
>> On Sun, Dec 23, 2018, at 5:54 AM, Mojca Miklavec wrote:
>>> Dear Ken,
>>> 
>>> On Sat, 22 Dec 2018 at 16:49, Ken Cunningham wrote:
>>>> 
>>>> I would like to propose we stop asking people to remove the "revision 0" line in Portfiles.
>>> 
>>> I totally agree.
>>> 
>>> I mean:
>>> - if users submit a PR with "revision 0", we should not ask them to
>>> remove that line
>>> - if users submit a PR with revision removed, we should not ask them
>>> to add it back either (at least not until we add that line to all
>>> other ports for some well-grounded reasons)
>>> - if users forget to change "revision 99" after version increase, we
>>> should still ask them to either remove it or change it to 0
>>> 
>>>> So how about we embrace the "0" and move on to stuff that matters more!!!
>>> 
>>> +1
>>> 
>>> Mojca
> 
> Marius
> 



More information about the macports-dev mailing list