[macports-ports] branch master updated: Rebuild port with boost 1.66.0

[Ryan Schmidt]

On Feb 17, 2018, at 14:37, Giovanni Bussi wrote:

> Eitan Adler (grimreaper) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/9b747847c18a6cea577b9849e6063d1f3d8bbec3
> 
> The following commit(s) were added to refs/heads/master by this push:
> 
>      new 9b74784  Rebuild port with boost 1.66.0
> 
> 9b74784 is described below
> 
> 
> commit 9b747847c18a6cea577b9849e6063d1f3d8bbec3
> 
> Author: Giovanni Bussi
> AuthorDate: Fri Feb 16 18:29:23 2018 +0100
> 
> 
>     Rebuild port with boost 1.66.0

Please put the name of the port and a colon as the first thing in the commit message, i.e. "plumed: rebuild plumed-devel with boost 1.66.0"


>     See 38c08eb5d757ac7790bceeb1a3f69a26223f7a2f
> 
> ---
>  science/plumed/Portfile | 1 -
>  1 file changed, 1 deletion(-)
> 
> 
> diff --git a/science/plumed/Portfile b/science/plumed/Portfile
> index b34dba0..5a01769 100644
> --- a/science/plumed/Portfile
> +++ b/science/plumed/Portfile
> @@ -104,7 +104,6 @@ pre-configure {
>  subport plumed-devel {
>      github.setup        plumed plumed2 d9be97c7bba3d165e130562033286537c23819d0
>      version             2.5-20180129
> -    revision            1
>      description         ${description} (development version)
>      long_description    ${long_description} (development version)
>      conflicts plumed

This is a confusing commit.

The confusion here stems from the fact that the portfile's global revision was already increased from 1 to 2, but it didn't take effect for the plumed-devel subport because it overrode the revision to 1.

I find it's less confusing if ports that have subports specify the revision individually for the main port and for each subport, including specifying "revision 0" when that's the case.