[macports-ports] branch master updated: Updated to latest package version Addressed comments Fixes: https://trac.macports.org/ticket/55769

[Ryan Schmidt]

On Jan 31, 2018, at 15:58, Ed Maros wrote:

> Frank Schima (mf2k) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/cb9a335ef7df55e354cd99e01e2a39727c8b1c75
> 
> The following commit(s) were added to refs/heads/master by this push:
> 
>      new cb9a335  Updated to latest package version Addressed comments Fixes: https://trac.macports.org/ticket/55769
> 
> cb9a335 is described below
> 
> 
> commit cb9a335ef7df55e354cd99e01e2a39727c8b1c75
> 
> Author: Ed Maros
> AuthorDate: Wed Jan 31 12:37:19 2018 -0800
> 
> 
>     Updated to latest package version
> 
>     Addressed comments
> 
>     Fixes: https://trac.macports.org/ticket/55769

Commit messages should begin with the name of the port, then a colon, then what was changed, in imperative mood, such as "gds: Update to 2.18.5". "latest version" isn't good language to use in a commit message because you want to be able to look back at commit messages years later and know what was done. "Addressed comments" isn't good language for a commit message either since it doesn't explain what those comments are.


> +if {${os.platform} eq "darwin" && ${os.major} >= 17 } {
> +    configure.env           CXXFLAGS='-std=c++1z'
> +
> +    depends_lib-append      port:root6
> +
> +	require_active_variants root6 python27
> +} else {
> +    configure.env           CXXFLAGS='-std=c++11'
> +
> +    depends_lib-append  port:root5
> +
> +	require_active_variants root5 python27
> +}

Shouldn't this be using configure.cxxflags-append instead of manipulating configure.env directly?

You used tabs on some of these lines. Please use only spaces, as the modeline claims.