[macports-ports] 02/02: py-parse: new port

[mf2k at macports.org]

Hi Dan,


A few comments on this:

> On Jul 25, 2018, at 5:26 AM, Dan Villiom Podlaski Christiansen <danchr at macports.org> wrote:
> 
> Dan Villiom Podlaski Christiansen (danchr) pushed a commit to branch master
> in repository macports-ports.
> 
> https://github.com/macports/macports-ports/commit/a4e4d89fd609ce7eaccbeb2915379b0c29990e9a <https://github.com/macports/macports-ports/commit/a4e4d89fd609ce7eaccbeb2915379b0c29990e9a>
> commit a4e4d89fd609ce7eaccbeb2915379b0c29990e9a
> Author: Dan Villiom Podlaski Christiansen <danchr at macports.org>
> AuthorDate: Wed Jul 25 13:26:04 2018 +0200
> 
>     py-parse: new port
> ---
>  python/py-parse/Portfile | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/python/py-parse/Portfile b/python/py-parse/Portfile
> new file mode 100644
> index 0000000..f62dae4
> --- /dev/null
> +++ b/python/py-parse/Portfile
> @@ -0,0 +1,29 @@
> +# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
> +
> +PortSystem 1.0
> +PortGroup           python 1.0
> +
> +name                py-parse
> +version             1.8.4
> +python.versions     27 34 35 36 37
In the future, for new python modules please don’t add py34 and py35 sub-ports. Let’s stick to just py36 and py37. 

> +license             BSD
> +platforms           darwin
> +supported_archs     noarch
> +maintainers         openmaintainer danchr @danchr
The maintainers line is not correct. You need to add braces to show that your Macports handle and Github handle are related. Also, by convention, your name should go first. So change it to this:

maintainers        {danchr @danchr} openmaintainer

> +
> +description         parse() is the opposite of format()
> +long_description    Parse strings using a specification based on the Python \
> +                    format() syntax -- parse() is the opposite of format()
> +
> +homepage            https://pypi.python.org/pypi/${python.rootname}/
> +
> +master_sites        pypi:[string index ${python.rootname} 0]/${python.rootname}
> +distname            ${python.rootname}-${version}
> +
> +checksums           sha256  c3cdf6206f22aeebfa00e5b954fcfea13d1b2dc271c75806b6025b94fb490939
For integrity reasons, please add the rmd160 checksum and also the size parameter. 
> +
> +
> +if {$name ne $subport} {
> +    depends_build-append  port:py${python.version}-setuptools
> +}
> +
> 

Cheers!
Frank

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macports.org/pipermail/macports-dev/attachments/20180725/fe2ffb72/attachment.html>