[macports-ports] branch master updated: grep: add new variant to install as ggrep

[Ryan Schmidt]

On Jun 20, 2018, at 23:15, Blair Zajac wrote:

> On Jun 20, 2018, at 7:21 PM, Ryan Schmidt wrote:
> 
>> On Jun 20, 2018, at 05:45, George Plymale II wrote:
>> 
>>> Marius Schamschula (Schamschula) pushed a commit to branch master
>>> in repository macports-ports.
>>> 
>>> 
>>> https://github.com/macports/macports-ports/commit/35915ffebeb3fc380ca45cdbde23e8ed9a8eb51d
>>> 
>>> The following commit(s) were added to refs/heads/master by this push:
>>> 
>>>    new 35915ff  grep: add new variant to install as ggrep
>>> 
>>> 35915ff is described below
>>> 
>>> 
>>> commit 35915ffebeb3fc380ca45cdbde23e8ed9a8eb51d
>>> 
>>> Author: George Plymale II
>>> AuthorDate: Tue Jun 19 23:33:37 2018 -0400
>>> 
>>> 
>>>   grep: add new variant to install as ggrep
>>> 
>>> ---
>>> sysutils/grep/Portfile | 6 +++++-
>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>> 
>> 
>>> +variant g_prefix description {Install the program as ggrep} {
>>> +    configure.args-append --program-prefix=g
>>> +}
>> 
>> Why are we offering this? Selecting this variant would break any port that depends on this port. We should strive not to provide users with ways of shooting themselves in the foot.
>> 
> 
> Besides this breaking change, it would be good to have this port be consistent with findutils and coretuils (and maybe the other GNU ports) which install with —program-prefix=g into $prefix/bin and have the non-g prefix in $prefix/libexec/gnubin so one can have $prefix/libexec/bin in $PATH and get the GNU versions if one wants them.

It is true that that is how most of the other GNU ports work. However, that would also break all of the ports that depend on the grep port. It would at least be more consistent than having this variant, but all the ports that depend on grep would need modifications to be compatible with your proposed change.