[macports-ports] branch master updated: grep: add new variant to install as ggrep
blair at orcaware.com
Sat Jun 23 23:08:23 UTC 2018
> On Jun 23, 2018, at 1:20 PM, George Plymale II <georgedp at orbitalimpact.com> wrote:
> Ryan Schmidt <ryandesign at macports.org> writes:
>> Your change makes the names of the programs that the grep port installs unpredictable -- they will be different depending on whether or not the user has selected the variant. Therefore, no other port or script can be certain of the names under which the programs have been installed. We definitely must revert the addition of the variant, so that the port can be relied upon to always install programs with predictable names.
>> We then have two choices. Choice 1 is to do nothing else and leave it as it was before your change. Choice 2 is to do what Blair suggests and make the port install the programs with the "g" prefix, and put unprefixed symlinks in the gnubin directory, as other GNU ports do. This would require changes to the two dozen other ports that declare dependencies on grep. If you wish to undertake that task, that's fine.
>> The way that I identify the portfiles that depend on grep is:
>> port file all | sort -u | xargs grep -El '^[^#]+:grep\W'
> Okay then. I will try and do what you suggest regarding Blair's
> changes. I think the path of consistency will be the best solution here,
> not just for my sake but for others too. It is probably best to try and
> make all GNU ports act the same in this regard.
> If I change all these files that are revealed by your incantation, must
> I make a separate pull request for each Portfile? Or can they all be put
> into one PR and / or commit?
I think for an atomic commit so they they are all changed together, it’s one PR/commit with multiple approvers. That way we won’t have an in-betwee inconsistent state.
More information about the macports-dev