Relax port lint rule for patchfile naming

Joshua Root jmr at macports.org
Fri Mar 16 22:22:40 UTC 2018


On 2018-3-17 09:05 , Mojca Miklavec wrote:
> On 16 March 2018 at 15:02, Ryan Schmidt wrote:
>>
>> On Mar 16, 2018, at 08:40, Mojca Miklavec wrote:
>>
>>> How will you distinguish patchfiles from others, like select lists, ed files, Makefiles etc?
>>
>> I wouldn't. If the author of the portfile finds that distinction important, they could continue to maintain it. port lint wouldn't care.
>>
>>> I support relaxing rules, but you cannot even rely on all files matching the relaxed version form.
>>
>> What do you mean? Do you have an example in mind?
> 
> I may be just confused. I didn't even know that lint would check the
> filenames under files/ folder. All I wanted to say is that if it does
> or if it will check, relaxing this condition would still result in
> warnings/errors unless lint would be able to distinguish patches from
> other types of files.
> 
> Relaxing the rule sounds totally reasonable. It just wasn't clear to
> me how you would distinguish patchfiles from other types of files.

The lint check in question doesn't look at the contents of files/, it
looks at the patchfiles option.

- Josh


More information about the macports-dev mailing list