Request for assistance closing some old pull requests
Perry E. Metzger
pmetzger at macports.org
Mon Mar 19 18:47:47 UTC 2018
On Mon, 19 Mar 2018 19:29:35 +0100 Rainer Müller
<raimue at macports.org> wrote:
[On the Wine 64 bit issue....]
> > So my understanding (and I might be mangling it) is that the issue
> > here is that there are two x86_64 registers that are reasonable
> > candidates for pointing at thread local data, and Windows has
> > picked a different one from macOS. The result of this is that a
> > register that Windows programs expect will be preserved gets
> > destroyed in the course of calling in to the rest of the OS.
>
> I have no idea how they solved it, but upstream claims that 64-bit
> is supported on macOS.
>
> I added more comments and commits to the PR:
> https://github.com/macports/macports-ports/pull/442
I think they haven't entirely solved it yet. That said, it looks like
it is strictly a better situation than what we have now. Do you think
you could take charge of finishing and committing this?
[On the protobuf-cpp to protobuf3-cpp issue...]
> Unfortunately, we have no support to run builds from pull requests
> or custom branches on the buildbot, as it would immediately publish
> the resulting archives.
>
> This sounds like a nice enhancement for our buildbot, though. On a
> forced build, we can already specify a branch name. If buildbot
> would only try to publish binary archives when running for the
> master branch, we could use it to test changes like this.
That would be a nice enhancement! Meanwhile, what would you suggest
would be reasonable here?
Perry
--
Perry E. Metzger pmetzger at macports.org
More information about the macports-dev
mailing list