[macports-ports] branch master updated: libphonenumber-cpp: update to version 8.9.2

[Ryan Schmidt]

On Mar 19, 2018, at 14:56, David B. Evans wrote:

> David B. Evans (dbevans) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/f5132e67a7da6bc7e68c40d75bd5e1f96fcd8f01
> 
> The following commit(s) were added to refs/heads/master by this push:
> 
>      new f5132e6  libphonenumber-cpp: update to version 8.9.2
> 
> f5132e6 is described below
> 
> 
> commit f5132e67a7da6bc7e68c40d75bd5e1f96fcd8f01
> 
> Author: David B. Evans
> AuthorDate: Mon Mar 19 12:53:41 2018 -0700
> 
> 
>     libphonenumber-cpp: update to version 8.9.2
>     
>     Allow build with either protobuf-cpp or protobuf3-cpp.
>     
>     See https://github.com/macports/macports-ports/pull/690
> 
> ---
>  devel/libphonenumber-cpp/Portfile | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)


> +# enable build with either protobuf-cpp or protobuf3-cpp
> +depends_lib-append  path:${prefix}/lib/libprotobuf.dylib:protobuf-cpp

This only works because protobuf-cpp and protobuf3-cpp install libprotobuf.dylib in the same place. I consider that a bug:

https://trac.macports.org/ticket/56102

If libphonenumber-cpp wants to let the user choose the version of protobuf-cpp, it should be done using two conflicting variants instead. For example, protobuf2_cpp and protobuf3_cpp variants.