Request for assistance closing some old pull requests
Ryan Schmidt
ryandesign at macports.org
Tue Mar 20 02:46:54 UTC 2018
On Mar 19, 2018, at 10:44, Perry E. Metzger wrote:
> There are a few pull requests that are pretty old and which I think
> are, de facto, stuck. I'd like to get some feedback about what to do
> about them.
>
> If we can close these three, we will have no PRs older than six months
> active in the system, which I think is a win.
>
> 1: wine*: add 64-bit support
> https://github.com/macports/macports-ports/pull/442
> Apr 22, 2017 (yes, almost a year old)
>
> This PR seems to be stuck on the fact that Wine de facto needs a 64
> bit version to be useful in a modern context,
Says who?
> but that macOS is likely
> permanently ABI incompatible with Wine 64.
>
> My proposal here is that we close the PR, and that we remove the Wine
> port as being unmaintainable going forward.
The wine ports work fine; I plan to keep them indefinitely, even if they stop working in a future version of macOS that can't run 32-bit programs, since they still work on older versions of macOS.
> 2: mosh: Switch to protobuf3-cpp
> https://github.com/macports/macports-ports/pull/690
> Aug 17, 2017
>
> Zero King correctly notes in the course of the PR's comment thread
> that protobuf3-cpp conflicts with protobuf-cpp, so all protobuf-cpp
> using ports probably should be migrated.
>
> This seems entirely straightforward to do (I made the needed changes
> in my own git repo in a couple of minutes) but rather difficult to
> test. To close this out, we probably need some volunteer who is in a
> position to test such an update.
I would prefer that the bug that protobuf-cpp and protobuf3-cpp install to the same place is fixed first:
https://trac.macports.org/ticket/56102
Then there's no reason why the ports can't be updated individually as time permits.
More information about the macports-dev
mailing list