[macports-ports] branch master updated: root6: update default compiler variants
Joshua Root
jmr at macports.org
Wed May 2 14:40:55 UTC 2018
On 2018-5-2 18:43 , Chris Jones wrote:
>
>
> On 02/05/18 07:07, Ryan Schmidt wrote:
>>
>> On May 1, 2018, at 12:52, Chris Jones wrote:
>>
>>> +# Enable variants that only seem to work when not using macports
>>> clang...
>>> +if [expr ![string match macports-clang-* ${configure.compiler}] ] {
>>> + default_variants-append +veccore +davix
>>> +}
>>
>> You don't really need [expr] here, do you?
>>
>
> It seemed to work, and I think I just copied the pattern above from
> another Portfile... What would you suggest instead (I'm, not super
> familiar with tcl..) ?
Should be:
if {![string match macports-clang-* ${configure.compiler}]} {
Yes the other version works, but expr effectively gets run twice because
the 'if' command does it internally.
- Josh
More information about the macports-dev
mailing list