Pull Request Etiquette

Mojca Miklavec mojca at macports.org
Sun May 20 06:26:30 UTC 2018


V ned., 20. maj 2018 00:06 je oseba Marcus Calhoun-Lopez napisala:

> There is a pull request to update Octave to 4.4.0.
> A significant amount of work has been put in to it.
> While attempting to address some of the outstanding issues, my version had
> diverged in some significant ways.
>
> Does anyone have any suggestions on the proper way forward?
>
> It seems inefficient to attempt to describe the changes in the current
> pull request comment section.
> It seems a little silly to open a competing pull request.
> Should I create a pull request on the pull request?
>

You cannot open a PR against a PR. If changes are significant, it's
probably best to open a new one and just mention in description that it was
inspired by <link>.

Mojca
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macports.org/pipermail/macports-dev/attachments/20180520/da4aa90a/attachment.html>


More information about the macports-dev mailing list