macports localinstall github tries to download from macports

[macports at parvis.nl]

> On 2020-04-28, at 06:02, Ryan Schmidt <ryandesign at macports.org> wrote:
> 
> 
> 
> On Apr 27, 2020, at 14:15, macports at parvis.nl <mailto:macports at parvis.nl> wrote:
> 
>> i’m trying to do a macports localinstall portgroup github for downtimed but it downloads from macports.org <http://macports.org/>, not github.com <http://github.com/>.
> 
> It attempts to download from all locations, including GitHub and the MacPorts mirrors. The file isn't on any of them because you've specified the wrong values to github.setup.
> 
> 
>> what is wrong here?
>> 
>> homepage: https://github.com/snabb/downtimed/releases
>> download: https://github.com/snabb/downtimed/archive/version-1.0.tar.gz
>> 
>> portfile:
>> 
>> PortSystem          1.0
>> PortGroup           github 1.0
>> github.setup        snabb downtimed 1.0
>> github.tarball_from archive
>> 
>> categories          sysutils
>> platforms           darwin
>> maintainers         nomaintainer
>> 
>> description         dateutils package
>> long_description    system downtime monitoring and reporting tool
>> 
>> checksums           rmd160  c168c31792c584054f3edd7cea14fe951604a76b \
>>                   sha256  00eb87d54b170e514c1d321c839bb2a7dd9ee3721bd08b96c91cda7f95e5e099 \
>>                   size    300337

Ken Cunningham told me to look at port distfiles (never thought of that).
the genarated url would be https://github.com/snabb/downtimed/archive/1.0/downtimed-1.0.tar.gz <https://github.com/snabb/downtimed/archive/1.0/downtimed-1.0.tar.gz> and that would cause the 404
he told me to remove github.tarball_from archive, but that failed too.
i should look into /opt/macports-ports/_resources/port1.0/group/github-1.0.tcl

Ryan Schmidt said:

> You want:
> 
> github.setup        snabb downtimed 1.0 version-
> github.tarball_from archive

but that results in https://github.com/snabb/downtimed/archive/version-1.0/downtimed-1.0.tar.gz (the version number in 2 places).

i tried some variants of distname and tried

github.setup        snabb downtimed 1.0
distname            version-${version}
master_sites        ${homepage}/archive

and that works. it this acceptable?

> P.S: Since your question is about developing a portfile, it would have been more appropriate to ask it on the macports-dev mailing list.

done.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macports.org/pipermail/macports-dev/attachments/20200428/fe12f106/attachment-0001.html>