Updating OpenSSH port to 8.4p1

[Ryan Schmidt]

On Oct 16, 2020, at 20:26, Blake Garner wrote:

> Thanks for the info and I'll have a look at the issues. I have setup a repo to test updated  and customized ports https://github.com/trodemaster/blakeports . Successfully rolled the version of openssh to 8.4p1 and incremented the port revision to 10. Currently I'm sorting through the patches. 
> 
> These ones work as expected
>  pam.patch
>  patch-sandbox-darwin.c-apple-sandbox-named-external.diff 
>  patch-sshd.c-apple-sandbox-named-external.diff
> 
> Not working
> 0002-Apple-keychain-integration-other-changes.patch   Homebrew has a thread on it here https://archive.is/hSB6d#10%25
> 
> Questioning if these are really needed?
> launchd.patch
> macports-config.patch
> patch-openbsd_compat-memmem-bug.diff
> 
> Some of these patches may be obsolete with the 8.4 version of openssh. I'm just searching the trac for info on each of them to get details. Any feedback is appreciated otherwise I'll just keep at it as I find time. 

You'll have to figure it out. You can look at the git history to discover when the patches were added / last updated and read the commit message(s) and/or linked ticket(s) to see why the patches exist. You can then decide whether they're still needed.

Generally I agree with the sentiment expressed in the homebrew thread you referred to above: we don't want to be in the business of forever maintaining extensive patches to software. Instead we want to provide the software that the developers have developed. If any patches are needed, they should be sent to the developers for inclusion in their code; then everyone benefits, not just us. If upstream is not willing to accept a patch, we should consider whether we should stop using that patch.