Git-devel has broken git-credential-osxkeychain.c for older systems

[Fred Wright]

On Sat, 20 Apr 2024, Saagar Jha wrote:

> Wait, I use osxkeychain. It’s basically a requirement if you’re pushing 
> to an authenticated server over HTTPS and don’t want to have to deal 
> with storing keys yourself. I suspect it is used a lot for this.

I have yet to see a Git repo that didn't allow you to push via SSH 
(git://) rather than HTTPS, and that's preferable, anyway.  I usually 
configure repos to use git:// in both directions, though git allows you to 
configure fetch and push separately if you want.

I avoid Keychain as much as I possibly can, after reading in some 
documentation somewhere that it stores all your passwords on the disk in 
cleartext the entire time you're logged in.

I have no objection to having the osxkeychain feature, but I don't 
recommend actually using it.

Fred Wright

>> On Apr 19, 2024, at 23:52, Kirill A. Korinsky <kirill at korins.ky> wrote:
>>
>> On Sat, 20 Apr 2024 00:25:47 +0200,
>> Sergio Had wrote:
>>>
>>> What do we do? :)
>>
>> To fix the build you have two options:
>> 1. Revert that patch for system before 10.7
>> 2. Remove folder contrib/credential/osxkeychain
>>
>> I suggest to follow (2) as simpler thay and the good news that osxkeychain
>> is something that isn't often used.