[MacPorts] #12914: "cd" TCL procedure should not be used in Portfiles anymore

MacPorts trac at macosforge.org
Sun Nov 18 00:43:54 PST 2007


#12914: "cd" TCL procedure should not be used in Portfiles anymore
-------------------------------+--------------------------------------------
  Reporter:  nox at macports.org  |       Owner:  ryandesign at macports.org
      Type:  defect            |      Status:  new                    
  Priority:  High              |   Milestone:  Port Bugs              
 Component:  ports             |     Version:  1.6.0                  
Resolution:                    |    Keywords:                         
-------------------------------+--------------------------------------------
Comment (by ryandesign at macports.org):

 I was using a convoluted shell pipeline to see whom to send the mail to:

 {{{
 port file all | \
 xargs grep "[[:space:]]cd[[:space:]]" | \
 grep -v "system[[:space:]]" | \
 sed -E 's%^.*/(.*)/Portfile.*$%\1%' | \
 uniq | \
 xargs port info --maintainer | \
 sed -e 's%^maintainer: %%' -e 's%,%%' | \
 xargs -n 1 echo | \
 sort | \
 uniq
 }}}

 This was unwieldy and besides did not take into account commented out
 lines or instructions printed in e.g. `ui_msg`s. So I wrote a more robust
 php script to figure it out. My current count is that 275 portfiles still
 need to be fixed, of which 123 are nomaintainer and 29 are openmaintainer.
 Thankfully jmpp has granted us a reprieve and MacPorts 1.6 will still have
 the `cd` command. So we have some more time to fix this.

 To use the new script to examine all portfiles, say:

 {{{
 port file all | php ports_using_cd.php
 }}}

 Or you can pipe in the paths of any subset of files you want examined. For
 example, to examine just the nomaintainer ports:

 {{{
 port file maintainer:nomaintainer | php ports_using_cd.php
 }}}

 I initially sent a mail to 17 maintainers. I'm not sure now how I arrived
 at that list; I currently count 69 maintainers who need to fix their
 ports. I'm not sending out a new mail just yet.

-- 
Ticket URL: <https://trac.macports.org/projects/macports/ticket/12914#comment:2>
MacPorts </projects/macports>
Ports system for Mac OS


More information about the macports-tickets mailing list