[MacPorts] #13368: libiconv 1.12_0 utf8mac patch shouldn't use "system"

[MacPorts]

#13368: libiconv 1.12_0 utf8mac patch shouldn't use "system"
-------------------------------------+--------------------------------------
 Reporter:  ryandesign at macports.org  |       Owner:  ryandesign at macports.org
     Type:  defect                   |      Status:  new                    
 Priority:  Normal                   |   Milestone:  Port Bugs              
Component:  ports                    |     Version:  1.5.2                  
 Keywords:                           |  
-------------------------------------+--------------------------------------
 libiconv 1.12_0 implements the utf8mac patch in a weird way:

 {{{
 post-patch {
         if {![variant_isset disable_utf8mac]} {
                 system "cd ${worksrcpath} && patch -p1 <
 ${filespath}/utf8mac.diff"
         }
 }
 }}}
 {{{
 variant disable_utf8mac {}
 }}}

 Why all this weirdness? The patch shouldn't need to use "`system`", it
 shouldn't need `-p1`. Reimplement this as a plain old ordinary patchfile.

-- 
Ticket URL: <https://trac.macosforge.org/projects/macports/ticket/13368>
MacPorts </projects/macports>
Ports system for Mac OS