[MacPorts] #16392: vtun 3.0.2 patch fix

[MacPorts]

#16392: vtun 3.0.2 patch fix
---------------------------------+------------------------------------------
  Reporter:  emertens at gmail.com  |       Owner:  macports-tickets at lists.macosforge.org
      Type:  defect              |      Status:  new                                  
  Priority:  Normal              |   Milestone:  Port Bugs                            
 Component:  ports               |     Version:  1.6.0                                
Resolution:                      |    Keywords:                                       
---------------------------------+------------------------------------------
Changes (by ryandesign at macports.org):

 * cc: ryandesign at macports.org (added)
  * milestone:  => Port Bugs


Comment:

 Let me make sure I understand.

 As shipped, vtun 3.0.2 has this set of definitions in
 lfd_legacy_encrypt.c:

 {{{
 #ifndef __APPLE_CC__
 /* OpenSSL includes */
 #include <openssl/md5.h>
 #include <openssl/blowfish.h>
 #else /* YAY - We're MAC OS */
 #include <sys/md5.h>
 #include <crypto/blowfish.h>
 #endif  /* __APPLE_CC__ */
 }}}

 In other words, on non-Mac OS X systems, it uses OpenSSL includes for md5
 and blowfish, and on Mac OS X it uses includes built into the operating
 system.

 The vtun 3.0.2_0 port has a [browser:trunk/dports/net/vtun/files/patch-
 lfd_legacy_encrypt.c.diff at 38368 patch] which makes the software always use
 the OpenSSL blowfish include, even on Mac OS X. I do not know why this was
 done; it has been there since the port was initially added in r6236.

 Now you are proposing that the md5 include should also be taken from
 OpenSSL, even on Mac OS X, effectively reducing the above definitions to
 this:

 {{{
 /* OpenSSL includes */
 #include <openssl/md5.h>
 #include <openssl/blowfish.h>
 }}}

 You have filed this ticket as a defect. What problem are you observing as
 a result of these includes -- or, if not a problem, what is gained by
 changing the includes? How can I reproduce the issue on my system so that
 I can confirm that your change is the correct fix? The port builds fine
 for me with or without your change, on Mac OS X 10.4.11 on Intel with
 Xcode 2.5. What version of Mac OS X and Xcode do you have, and on which
 processor architecture?

-- 
Ticket URL: <http://trac.macports.org/ticket/16392#comment:1>
MacPorts <http://www.macports.org/>
Ports system for Mac OS