[MacPorts] #12580: [NEW]: Shiira-2.2
MacPorts
trac at macosforge.org
Sat Feb 23 12:10:09 PST 2008
#12580: [NEW]: Shiira-2.2
--------------------------------------------+-------------------------------
Reporter: themiwi at users.sourceforge.net | Owner: jmr at macports.org
Type: enhancement | Status: reopened
Priority: Normal | Milestone: Port Submissions
Component: ports | Version:
Resolution: | Keywords:
--------------------------------------------+-------------------------------
Changes (by ryandesign at macports.org):
* status: closed => reopened
* resolution: fixed =>
Comment:
The port overrides the `destroot` phase and makes use of the `cd` command
which will disappear in MacPorts 1.7, so it should not be used. I'm not
sure the `destroot` phase needs to be overridden in the first place.
Instead of this...
{{{
destroot {
cd ${worksrcpath}
system "${build.cmd} install ${build.target} \
INSTALL_PATH=/Applications/MacPorts
\
INSTALL_MODE_FLAG=go-w,a+rX DSTROOT=${destroot}"
}
}}}
...why not something like this (untested, but something like this should
work):
{{{
destroot.post_args ${build.target}
destroot.destdir INSTALL_PATH=/Applications/MacPorts
INSTALL_MODE_FLAG=go-w,a+rX DSTROOT=${destroot}
}}}
Also, the `exit` command does not exist in MacPorts 1.6 already. And you
only want to print a message if the user is actually on his way to
installing something. The way this is written now, the message will also
be printed if something like `port info` is used, which is not desired.
The usual solution is to print the message in the `pre-fetch` phase. So
instead of this...
{{{
platform darwin {
if {${os.major} < 8} {
ui_msg "Shiira 2 needs Mac OS X 10.4 \'Tiger\' or later."
exit 1
}
}
}}}
...do this:
{{{
platform darwin {
if {${os.major} < 8} {
pre-fetch {
return -code error "Shiira 2 needs Mac OS X 10.4
\"Tiger\" or later."
}
}
}
}}}
Finally, the portfile uses a haphazard mix of spaces and tabs for
indentation and alignment. You should pick just one, preferably converting
all tabs to spaces. Please commit whitespace changes separately from
functional changes.
--
Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/12580#comment:4>
MacPorts </projects/macports>
Ports system for Mac OS
More information about the macports-tickets
mailing list