[MacPorts] #13972: New Port qmail-spamcontrol

[MacPorts]

#13972: New Port qmail-spamcontrol
---------------------------------------+------------------------------------
  Reporter:  compconsultant at yahoo.com  |       Owner:  ryandesign at macports.org
      Type:  enhancement               |      Status:  new                    
  Priority:  Normal                    |   Milestone:  Port Submissions       
 Component:  ports                     |     Version:  1.6.0                  
Resolution:                            |    Keywords:  qmail                  
---------------------------------------+------------------------------------
Changes (by ryandesign at macports.org):

 * cc: steve at fatula.us (added)

Comment:

 Ok! First of all thank you for your submission. I think I've made all the
 changes I'm going to make for now. The original version of the Portfile
 was 18,248 bytes, 366 lines. After all the above changes, the new Portfile
 is 8331 bytes, 251 lines. Much better!

 These questions remain:

  * Could you create a description for each variant please? (`port lint`
 reminds you to do this.)
  * The definition of `PATH` at the top of qmailctl includes `/bin` twice
 but not `/sbin` or `/usr/sbin`. Is that how it should be? I would think
 that since you're including `${prefix}/sbin` and `/usr/local/sbin` you
 would want the other `sbin` directories too. Actually, are you sure you
 want to include `/usr/local` directories there? Software installed using
 MacPorts should really not be using anything that might be in
 `/usr/local`.
  * Do the turdfiles cause problems for qmail or why are you removing them?
 If they do not cause a problem you should not remove them. If they do
 cause a problem, then you should explain this in the comment in the post-
 activate phase, and you should also re-examine the second line of the
 post-activate phase (which tries to remove
 `${destroot}${prefix}/var/log/qmail/smtpd/.turd_${name}`) because it has
 no effect: at the activate phase, there is no ${destroot} anymore.

 If you could attach portfile patches to address these issues that would be
 great.

-- 
Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/13972#comment:16>
MacPorts </projects/macports>
Ports system for Mac OS