[MacPorts] #15550: luarocks patch

MacPorts noreply at macports.org
Sat Jun 7 23:37:20 PDT 2008


#15550: luarocks patch
-------------------------------------+--------------------------------------
 Reporter:  ryandesign at macports.org  |       Owner:  andrea.damore at macports.org
     Type:  defect                   |      Status:  new                       
 Priority:  Normal                   |   Milestone:  Port Bugs                 
Component:  ports                    |     Version:  1.7.0                     
 Keywords:                           |  
-------------------------------------+--------------------------------------
 Here's a patch to fix some issues with luarocks, I think. (I don't
 actually use luarocks).

  * You have variants openssl and md5 which I think you intend to be
 conflicting with one another, but they're not marked as such. Same goes
 for variants wget and curl.
  * Your variants include statements to remove dependencies and configure
 arguments which have never been added in the first place.
  * The port declared a dependency on wget by default even though wget is
 now a variant.
  * I think you meant for one of openssl and md5 to always be selected, and
 one of wget and curl to always be selected, but didn't write the portfile
 that way. It was possible to install it with no variant selected.
  * You had the dependencies declared as library dependencies, but the port
 installs only text files, no binaries, so it doesn't use any libraries.
 Rather, these are runtime dependencies.
  * Since the port installs no binaries, the universal variant should be
 disabled. Attempting to use the universal variant results in the error
 "Unknown flag: --disable-dependency-tracking"

 Remaining issues not solved by my patch:

  * Your md5 variant configures luarocks to use the md5sum program to check
 files, but Mac OS X does not include the md5sum program. You can get it by
 installing the coreutils port, but there it's called gmd5sum, unless
 coreutils is installed with the with_default_names variant. So either
 change the md5 variant to use the gmd5sum program and declare a dependency
 on port:coreutils, or maybe just remove the md5 variant altogether (unless
 there's a big advantage to using gmd5sum vs. openssl that I'm not aware
 of).

-- 
Ticket URL: <http://trac.macports.org/ticket/15550>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list