[MacPorts] #15187: dcraw-8.86 Checksum error

MacPorts trac at macosforge.org
Sat May 3 19:31:10 PDT 2008


#15187: dcraw-8.86 Checksum error
-----------------------------+----------------------------------------------
  Reporter:  john at fstop.org  |       Owner:  ryandesign at macports.org
      Type:  defect          |      Status:  assigned               
  Priority:  Normal          |   Milestone:  Port Bugs              
 Component:  ports           |     Version:  1.6.0                  
Resolution:                  |    Keywords:  dcraw checksum         
-----------------------------+----------------------------------------------
Changes (by ryandesign at macports.org):

  * status:  new => assigned

Comment:

 Looks like the developer did a stealth-upgrade. Here's the difference
 between the old and new 8.86:

 {{{
 diff -ru 8.86_0/dcraw/dcraw.c 8.86_1/dcraw/dcraw.c
 --- 8.86_0/dcraw/dcraw.c        2008-04-20 03:09:37.000000000 -0500
 +++ 8.86_1/dcraw/dcraw.c        2008-04-29 13:22:52.000000000 -0500
 @@ -19,8 +19,8 @@
     *If you have not modified dcraw.c in any way, a link to my
     homepage qualifies as "full source code".

 -   $Revision: 1.402 $
 -   $Date: 2008/04/20 08:09:37 $
 +   $Revision: 1.403 $
 +   $Date: 2008/04/29 18:18:53 $
   */

  #define VERSION "8.86"
 @@ -922,7 +922,7 @@
      for (jcol=0; jcol < jwide; jcol++) {
        val = *rp++;
        if (jh.bits <= 12)
 -       val = curve[val];
 +       val = curve[val & 0xfff];
        if (cr2_slice[0]) {
         jidx = jrow*jwide + jcol;
         i = jidx / (cr2_slice[1]*jh.high);
 @@ -5941,7 +5941,8 @@
           data_offset = off+24;
         }
         fseek (ifp, off+28, SEEK_SET);
 -       if (fgetc(ifp) == 0xff && fgetc(ifp) == 0xd8) {
 +       if (fgetc(ifp) == 0xff && fgetc(ifp) == 0xd8
 +               && thumb_length < len-28) {
           thumb_offset = off+28;
           thumb_length = len-28;
           write_thumb = &CLASS jpeg_thumb;
 }}}

 I'll update the portfile.

-- 
Ticket URL: <http://trac.macosforge.org/projects/macports/ticket/15187#comment:2>
MacPorts </projects/macports>
Ports system for Mac OS


More information about the macports-tickets mailing list