[MacPorts] #15033: make openssl universal_archs-aware
MacPorts
noreply at macports.org
Thu May 29 04:48:15 PDT 2008
#15033: make openssl universal_archs-aware
-------------------------------+--------------------------------------------
Reporter: jmr at macports.org | Owner: mww at macports.org
Type: enhancement | Status: new
Priority: Normal | Milestone: Port Enhancements
Component: ports | Version:
Resolution: | Keywords: haspatch
-------------------------------+--------------------------------------------
Comment (by ryandesign at macports.org):
This looks good, except that it doesn't work on MacPorts 1.6.0 (says
`Error: Target org.macports.patch returned: can't read "universal_archs":
no such variable`), and the patch uses inconsistent whitespace for
indentation.
I'll attach a revised patch which:
* uses consistent tab indentation to match the portfile
* sets `universal_archs` outside of the universal variant so it's set
when the other phases come around
* uses curly braces around all variable references
* abstracts out the one change in the three `./Configure` invocations
into a new variable `${my_cc}` and calls `./Configure` in just one place
Problems that still remain:
* the part that searches for differences between files assumes "i386" is
among the requested architectures (not necessarily so if the user modified
`universal_archs`)
* the part that searches for differences between files checks for
differences between "i386" and "i386" which it needn't do
The `${first_arch}` code in the cairo port's universal variant may be
helpful. (Note that the cairo port's universal variant is not working in
cairo 1.6.4, but the mechanism is sound since it did work in 1.4.14. See
#15451.)
--
Ticket URL: <http://trac.macports.org/ticket/15033#comment:2>
MacPorts <http://www.macports.org/>
Ports system for Mac OS
More information about the macports-tickets
mailing list