[MacPorts] #19142: faac doesn't support mp4

[MacPorts]

#19142: faac doesn't support mp4
---------------------------------+------------------------------------------
 Reporter:  anddam@…             |       Owner:  pguyot@…           
     Type:  defect               |      Status:  new                
 Priority:  Normal               |   Milestone:  Port Bugs          
Component:  ports                |     Version:  1.7.0              
 Keywords:  faac mp4 support     |        Port:  faac               
---------------------------------+------------------------------------------

Comment(by devans@…):

 Good idea about dropping a line.

 Concerning --with-mp4v2, upon review, its a little of both ;-)

 Here are the lines from configure.in
 {{{
 AM_CONDITIONAL(WITH_MP4V2, false)

 AC_CHECK_DECLS([MP4Create, MP4MetadataDelete],
                AC_CHECK_LIB(mp4v2, MP4MetadataDelete, external_mp4v2=yes,
                             external_mp4v2=no, -lstdc++),
                external_mp4v2=no, [#include <mp4.h>])

 if test x$external_mp4v2 = xyes; then
   AC_MSG_NOTICE([*** Building with external mp4v2 ***])
 else
   if test x$WITHMP4V2 = xyes; then
      AC_MSG_NOTICE([*** Building with internal mp4v2 ***])
      AM_CONDITIONAL(WITH_MP4V2, true)
      AC_CONFIG_LINKS(common/mp4v2/mpeg4ip_config.h:config.h)
      MY_DEFINE(HAVE_LIBMP4V2)
   else
      AC_MSG_NOTICE([*** Building WITHOUT mp4v2 ***])
   fi
 fi
 }}}

 So you can see that if --with-mp4v2 is set it tries to build from the
 internal source but only
 if an external library is not found.  From our point of view this option
 should make no difference
 at all, since the external library exists.  So the question remains
 whether this actually links
 in the external library or not.

 Anyway, should resolve the issue with the current libmp4v2 first and then
 worry about the new version.
 Please double check your results against the current libmp4v2 port and
 I'll do the same.

 If you file a ticket/report upstream please reference it here.

-- 
Ticket URL: <http://trac.macports.org/ticket/19142#comment:5>
MacPorts <http://www.macports.org/>
Ports system for Mac OS