[MacPorts] #19325: vlc: remove aqua variant

[MacPorts]

#19325: vlc: remove aqua variant
-------------------------------------+--------------------------------------
 Reporter:  ryandesign@…             |       Owner:  max@…            
     Type:  enhancement              |      Status:  new              
 Priority:  Normal                   |   Milestone:  Port Enhancements
Component:  ports                    |     Version:  1.7.1            
 Keywords:                           |        Port:  vlc              
-------------------------------------+--------------------------------------

Comment(by ryandesign@…):

 Replying to [comment:1 max@…]:
 > What the +aqua variant does is create VLC.app and install it in
 ${applications_dir}.

 That's what I thought.

 > Without this variant there will be just a vlc executable in
 ${prefix}/bin.

 Yes, I didn't mean you should remove this functionality.

 > I think moving this to platform macosx wouldn't be appropriate. I could
 remove the variant at all if you feel it is unnecessary and always
 create/install VLC.app or rename it to something different

 My issue is not with the name of the variant, my issue is with there being
 a variant for this at all. Why would anyone want to turn it off? Just do
 it all the time, on Mac OS X.

 My reason for suggesting doing this in the "platform macosx" section is so
 that it does not impact users installing vlc on other operating systems.
 However, I see the portfile already has other things in it that are Mac OS
 X-specific. I also see now that the "destroot.target" line already
 contains "install VLC.app" always. The aqua variant does nothing but
 append "VLC.app" to "destroot.target" again, so it's completely
 ineffective anyway. So you could either move all of the Mac OS X-specific
 stuff to the "platform macosx" section, or you could decide that the vlc
 port will only work on Mac OS X. In the latter case, you can simply remove
 the aqua variant, and also change the "platforms" line from "darwin" to
 "macosx".

-- 
Ticket URL: <http://trac.macports.org/ticket/19325#comment:2>
MacPorts <http://www.macports.org/>
Ports system for Mac OS