[MacPorts] #20525: testdisk: new version available

[MacPorts]

#20525: testdisk: new version available
-------------------------------------------------+--------------------------
  Reporter:  michael.klein@…                     |       Owner:  ryandesign@…           
      Type:  update                              |      Status:  closed                 
  Priority:  Normal                              |   Milestone:                         
 Component:  ports                               |     Version:  1.7.1                  
Resolution:  fixed                               |    Keywords:                         
      Port:  testdisk                            |  
-------------------------------------------------+--------------------------

Comment(by ryandesign@…):

 Replying to [comment:3 michael.klein@…]:
 > testdisk has quite a few optional dependencies on ports like jpeg or
 ntfsprogs.  With the above fix the configure script won't find the ntfs
 headers any more even if ntfsprogs is installed.

 A port must not use software it does not declare dependencies on. If we
 want to have options to use that software, variants should be added that
 add those dependencies and tell the software it is alright to use that
 software.

 The port needs some dependencies added anyway; see #20528.

 > I'd like to suggest to add the following instead:[[br]]
 > [[br]]
 > configure.cppflags-append       [exec sh -c "uuid-config --cflags
 2>/dev/null; exit 0"][[br]]
 > configure.ldflags-append        [exec sh -c "uuid-config --ldflags
 --libs 2>/dev/null; exit 0"]

 Well, you can't call a program (like uuid-config) that's provided by
 another port unless you do it in a phase. We could do that in a pre-
 configure phase. I simplified your suggestion a bit and tried adding

 {{{
 pre-configure {
     configure.cppflags-append [exec uuid-config --cflags]
     configure.ldflags-append [exec uuid-config --ldflags --libs]
 }
 }}}

 to the port and now it compiles again. But in r54839 we just removed ossp-
 uuid as a dependency, and with the above changes, it now links again with
 ossp-uuid. Are you saying the dependency on ossp-uuid should be added back
 in? The other option is to find a way to tell testdisk not to use ossp-
 uuid even if it is present.

-- 
Ticket URL: <http://trac.macports.org/ticket/20525#comment:4>
MacPorts <http://www.macports.org/>
Ports system for Mac OS