[MacPorts] #22106: apbs-mpi-1.1.0 package

[MacPorts]

#22106: apbs-mpi-1.1.0 package
--------------------------------------+-------------------------------------
 Reporter:  howarth@…                 |       Owner:  macports-tickets@…                   
     Type:  submission                |      Status:  new                                  
 Priority:  Normal                    |   Milestone:                                       
Component:  ports                     |     Version:  1.8.1                                
 Keywords:  science                   |        Port:  apbs-mpi                             
--------------------------------------+-------------------------------------

Comment(by macsforever2000@…):

 My initial comments:

  * Your email address should be obfuscated.
  * The version is hardcoded a few places. ${version} should be used
 instead.
  * The distfiles line is redundant and has the version hardcoded, so it
 should be removed.
  * In destroot, directories are moved with the system command, but this is
 frowned on. Tcl commands should be used. However the guide does not not
 really give a good way to do this. Are there too many files to use a for
 each loop like in the qt4-mac portfile?

-- 
Ticket URL: <http://trac.macports.org/ticket/22106#comment:1>
MacPorts <http://www.macports.org/>
Ports system for Mac OS