[MacPorts] #16666: Update apple-gcc42 to rev 5564 and include c++ support (was: Update apple-gcc42 to rev 5564 and include c++ suport)

MacPorts noreply at macports.org
Sat Feb 7 15:07:52 PST 2009


#16666: Update apple-gcc42 to rev 5564 and include c++ support
--------------------------------------------------+-------------------------
 Reporter:  illogical1@…                          |       Owner:  mww@…           
     Type:  defect                                |      Status:  new             
 Priority:  Normal                                |   Milestone:  Port Bugs       
Component:  ports                                 |     Version:  1.6.0           
 Keywords:  apple-gcc42 c++ inline-asm apple gcc  |        Port:  apple-gcc42     
--------------------------------------------------+-------------------------

Comment(by ryandesign@…):

 It's hard to get a diff between the current Portfile and your
 [attachment:Portfile.3 Portfile.3] because you've changed changed a lot of
 the whitespace. Let's leave the whitespace the way the maintainer has it,
 or you can file another ticket if you'd like the maintainer to consider
 reformatting the whitespace.

 In Portfile.3 you've added this:

 {{{
 pre-activate {
     system "mkdir -p ${destroot}${prefix}"
     system "mv -f ${destroot}${build_prefix}/* ${destroot}${prefix}"
     system "rmdir ${destroot}${build_prefix}"
 }
 }}}

 I'm not sure how that can work, since by the time the pre-activate code is
 run, everything from the destroot has already been installed into its
 final destination in ${prefix}/var/macports/software/${name}/... It might
 work if you change "pre-activate" to "destroot". Though you don't need to
 use "system" for any of these tasks, I think.

 I had not seen before that the build.cmd includes a reference to the
 destroot location, so maybe that is enough for the files to get to the
 right place. I'll try it.

 There are just a lot of changes in the portfile. Were there a lot of
 changes upstream between 5531 and 5564 that made this necessary?

-- 
Ticket URL: <http://trac.macports.org/ticket/16666#comment:18>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list