[MacPorts] #18603: mp3fs: cannot install if prefix is not /opt/local and other issues

[MacPorts]

#18603: mp3fs: cannot install if prefix is not /opt/local and other issues
-------------------------------------+--------------------------------------
 Reporter:  ryandesign@…             |       Owner:  mail@…          
     Type:  defect                   |      Status:  new             
 Priority:  Normal                   |   Milestone:  Port Bugs       
Component:  ports                    |     Version:  1.7.0           
 Keywords:                           |        Port:  mp3fs           
-------------------------------------+--------------------------------------
 There were some issues with the mp3fs port as it was submitted in #18381,
 first mentioned on macports-dev [http://lists.macosforge.org/pipermail
 /macports-dev/2009-February/007231.html by Rainer] and
 [http://lists.macosforge.org/pipermail/macports-
 dev/2009-February/007233.html by myself]:

  1. The lines "`distname mp3fs-${version}`" and "`livecheck.distname
 mp3fs`" should be removed because those are the default values.
  2. pkgconfig should be marked as a build dependency, not a library
 dependency.
  3. Patchfiles should not reside on your personal web space; they should
 instead be copied to the port's files directory.
  4. The string "`/opt/local`" should usually not occur in a portfile,
 because MacPorts might be installed in a different prefix. Use the
 variable "`${prefix}`" instead.

 1, 2, and 3 were fixed by Jeremy in r46512. 4 was partially fixed in that
 revision but one occurrence of /opt/local remained, so the port still
 doesn't work if the prefix is not /opt/local.

 Some additional points that occur to me now:

  5. Your configure arguments should not be appended to
 "`configure.post_args`" but instead should be written to
 "`configure.args`" and there is no need to enclose them in quotes.
  6. There is no need to use "`master_sites sourceforge:mp3fs`"; if the
 SourceForge project name is the same as the port name you can just say
 "`master_sites sourceforge`"
  7. You should not put ${distfiles} into the checksums. It is unnecessary
 if ${distfiles} contains only a single file, as it does in this case, and
 it is a syntax error if it contains multiple files.

 I'll attach a patch to fix these remaining issues. If you agree, I'll be
 happy to commit it.

-- 
Ticket URL: <http://trac.macports.org/ticket/18603>
MacPorts <http://www.macports.org/>
Ports system for Mac OS