[MacPorts] #19485: AntTweakBar Portfile addition

MacPorts noreply at macports.org
Sun Jun 14 08:36:18 PDT 2009


#19485: AntTweakBar Portfile addition
------------------------------+---------------------------------------------
 Reporter:  karcaw@…          |       Owner:  macports-tickets@…                   
     Type:  submission        |      Status:  new                                  
 Priority:  Normal            |   Milestone:                                       
Component:  ports             |     Version:  1.7.1                                
 Keywords:                    |        Port:                                       
------------------------------+---------------------------------------------

Comment(by jmr@…):

 Some things that should be changed:
  * Setting distfiles explicitly is discouraged, as is hardcoding the name,
 version and extract.suffix in it. Try this instead:
  {{{
 distname           ${name}_[join [split ${version} .] ""]
  }}}
  That way, distfiles will automatically stay correct when version is
 changed.
  * `patch.pre_args` defaults to `-p0`, so there's no need to set it to
 that.
  * Instead of making a link to the extracted directory, just set
 worksrcdir like this:
  {{{
 worksrcdir          ${name}
  }}}
  * The build system compiles with 'gcc'. This could point to any gcc
 version, so for consistency, it should be made to use the value of
 ${configure.cc} instead.
  * It also passes `-I/usr/local/include -I/usr/X11R6/include` to the
 compiler. Ports should not normally use anything from these locations, and
 problems can result if conflicting headers are installed there.
  * Regarding the patch, `$(PREFIX)` starts with a slash, so
 `$(DESTDIR)/$(PREFIX)` ends up having a double slash.

-- 
Ticket URL: <http://trac.macports.org/ticket/19485#comment:1>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list