[MacPorts] #22497: pidgin 2.6.2 missing file in Applying patches stage

MacPorts noreply at macports.org
Thu Nov 12 15:56:47 PST 2009


#22497: pidgin 2.6.2 missing file in Applying patches stage
--------------------------+-------------------------------------------------
 Reporter:  senz@…        |       Owner:  ryandesign@…           
     Type:  defect        |      Status:  assigned               
 Priority:  Normal        |   Milestone:                         
Component:  ports         |     Version:  1.8.1                  
 Keywords:                |        Port:  pidgin                 
--------------------------+-------------------------------------------------
Changes (by ryandesign@…):

 * cc: ryandesign@… (removed)
  * owner:  macports-tickets@… => ryandesign@…
  * status:  new => assigned


Comment:

 Two problems in the +quartz variant's post-patch block:

 {{{
     post-patch {
         reinplace "s|@INTLTOOL_ICONV@|${prefix}/bin/iconv|g" intltool-
 merge.in
         system "${filespath}/autogen.sh"
     }
 }}}

  1. The reinplace assumes we're in ${worksrcpath}. Ports were never meant
 to assume that was the case, but many did. As of MacPorts 1.8.0 this is no
 longer true, so it now fails to find the to-be-reinplaced file. But more
 importantly, the file does not contain the to-be-replaced string. (The
 file is totally empty.) The reinplace can just be removed completely.
  2. The autogen.sh invocation also assumes we're in ${worksrcpath}. Since
 we're not, it should `cd` to ${worksrcpath} first.

-- 
Ticket URL: <http://trac.macports.org/ticket/22497#comment:3>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list