[MacPorts] #21170: gcc_select: incorrect error message

[MacPorts]

#21170: gcc_select: incorrect error message
-------------------------------------+--------------------------------------
 Reporter:  akim.demaille@…          |       Owner:  macports-tickets@…                   
     Type:  defect                   |      Status:  new                                  
 Priority:  Normal                   |   Milestone:                                       
Component:  ports                    |     Version:  1.8.0                                
 Keywords:                           |        Port:  gcc_select                           
-------------------------------------+--------------------------------------
 When there are errors, gcc_select reports that there are "0 errors".  The
 problem is:

 {{{
 select_version ${1}
 if [ 0 != ${?} ]; then
         echo "there were ${?} errors selecting version \"${version}\"!"
         exit 5
 fi
 }}}

 The test {{{0 != ${?}}}} changes the current status, so next time ${?} is
 used, in the message, it has changed.

 While trying to fix this, I originally thought the error was elsewhere, so
 I accidentally improved other parts of the code.  I think these changes
 are worth being included, although they are not really needed.

-- 
Ticket URL: <http://trac.macports.org/ticket/21170>
MacPorts <http://www.macports.org/>
Ports system for Mac OS