[MacPorts] #21471: Scribus 1.3.5.1
MacPorts
noreply at macports.org
Sun Sep 20 23:17:06 PDT 2009
#21471: Scribus 1.3.5.1
--------------------------------+-------------------------------------------
Reporter: vince@… | Owner: macports-tickets@…
Type: update | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Keywords: | Port: scribus
--------------------------------+-------------------------------------------
Changes (by ryandesign@…):
* cc: ryandesign@… (added)
Comment:
Some notes:
* "bin:bin/foo:bar" is not valid syntax. You want "path:bin/foo:bar".
* Your long_description has nonbreaking spaces in it, and appears to be
missing newlines after some of its backslashes.
* Your Portfile is using tabs, at 2-spaces-per-tab indentation. The
existing scribus port is using spaces, with columns at multiples of four
spaces, which is what we prefer.
* You said this should go in a new port, but you still called the port
scribus. I don't think I would make it a new port. Or is there a
compelling reason why someone would prefer to use the older version?
* Whether or not this will be a new port or update the existing one, your
update should not make unrelated whitespace changes, otherwise it's
difficult to see what functional changes were made. If you want whitespace
changes made, we can do that, but in a separate commit that does nothing
but change the whitespace. (But changing spaces to tabs is not acceptable
because we want to move ports toward using spaces, not away from them.)
--
Ticket URL: <http://trac.macports.org/ticket/21471#comment:3>
MacPorts <http://www.macports.org/>
Ports system for Mac OS
More information about the macports-tickets
mailing list