[MacPorts] #24340: libao: patch phase fails on 10.5 and earlier
MacPorts
noreply at macports.org
Sat Apr 3 16:37:15 PDT 2010
#24340: libao: patch phase fails on 10.5 and earlier
-------------------------------------+--------------------------------------
Reporter: ryandesign@… | Owner: macports-tickets@…
Type: defect | Status: new
Priority: Normal | Milestone:
Component: ports | Version: 1.8.2
Keywords: | Port: libao
-------------------------------------+--------------------------------------
Comment(by ryandesign@…):
It looks like ao_macosx.c used to use the deprecated version 1 Audio Unit
interface (which was removed in 10.6), and our patchfile upgraded it to
use the new version 2 interface. It looks like this patch has more or less
been incorporated upstream. Or maybe we originally took it from upstream
and then they changed the source further. It's difficult to evaluate the
patch because in addition to tons of functional changes, it contains an
infuriating amount of whitespace-only changes.
My first instinct is to simply remove the patchfile, but the build then
fails on Tiger with:
{{{
ao_macosx.c:74: error: parse error before 'AudioComponentInstance'
}}}
I haven't tested Leopard yet.
The 1.0.0 source says "AudioComponentInstance outputAudioUnit;" whereas
our patch used "AudioUnit outputAudioUnit;"
The 1.0.0 source does contain the comment "This plugin will only build on
a 10.6 or later Mac (Darwin 9+)"; confused though this may be about
Leopard vs. Snow Leopard, it suggests their version doesn't work on Tiger.
--
Ticket URL: <http://trac.macports.org/ticket/24340#comment:5>
MacPorts <http://www.macports.org/>
Ports system for Mac OS
More information about the macports-tickets
mailing list