[MacPorts] #27606: Web Polygraph

[MacPorts]

#27606: Web Polygraph
------------------------------+---------------------------------------------
  Reporter:  fclaire@…        |       Owner:  ryandesign@…           
      Type:  submission       |      Status:  closed                 
  Priority:  Normal           |   Milestone:                         
 Component:  ports            |     Version:  1.9.2                  
Resolution:  fixed            |    Keywords:                         
      Port:  polygraph        |  
------------------------------+---------------------------------------------
Changes (by ryandesign@…):

  * status:  assigned => closed
  * resolution:  => fixed


Comment:

 I committed the port in r74213 with the exception that I deleted the
 following lines, which have no purpose in this port:

 {{{
 variant universal {}
 if {[variant_isset universal]} {
     set archflags       ${configure.universal_cflags}
 } else {
     set archflags       ${configure.cc_archflags}
 }
 }}}

 In these lines, you're setting the archflags variable to a value depending
 on whether the universal variant is set... but then you don't ever
 actually use the archflags variable anywhere.

 I imagine you probably copied these lines from another port where they did
 have a purpose. That other port probably also included a line that made
 use of the archflags variable, for example:

 {{{
 build.args              CC="${configure.cc} ${archflags}"
 }}}

 This would pass the archflags, along with the compiler name, to the CC
 environment variable, which would be used by the software's Makefiles.
 This manual setting of the archflags is necessary to add universal and
 non-default-build_arch support to ports for software that does not use a
 standard configure script. Since polygraph does use a standard configure
 script, there's no need to do this manually; MacPorts already handles it
 automatically by passing the necessary environment variables to the
 configure script during the configure phase.

-- 
Ticket URL: <https://trac.macports.org/ticket/27606#comment:2>
MacPorts <http://www.macports.org/>
Ports system for Mac OS