[MacPorts] #23325: clhep config scripts include architectures

MacPorts noreply at macports.org
Sat Feb 13 20:57:40 PST 2010


#23325: clhep config scripts include architectures
--------------------------------------+-------------------------------------
  Reporter:  ryandesign@…             |       Owner:  cristiano.fontana@…        
      Type:  defect                   |      Status:  closed                     
  Priority:  Normal                   |   Milestone:                             
 Component:  ports                    |     Version:  1.8.2                      
Resolution:  fixed                    |    Keywords:                             
      Port:  clhep                    |  
--------------------------------------+-------------------------------------
Changes (by ryandesign@…):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 Your patch does not work for many reasons:

  * square brackets inside double quotes are interpreted by tcl; you need
 to either escape square brackets with a backslash or use curly quotes
 instead of double quotes
  * you need to specify the full path to the files you're reinplacing; do
 not assume any particular working directory
  * more files than just clhep-config are affected; to see all the files
 that are affected you can use `port contents clhep | sed 1d | xargs grep
 -- ' -arch '`

 The above suggests to me you did not test your patch. Please test your
 patches before submitting them.

 You also need to increase the port's revision when making changes that
 alter the contents of files installed by the port.

 I have fixed the issue in r63750.

-- 
Ticket URL: <http://trac.macports.org/ticket/23325#comment:2>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list