[MacPorts] #23420: qhull-2010.1 Fix list and location of installed header files

MacPorts noreply at macports.org
Sun Jan 31 15:26:43 PST 2010


#23420: qhull-2010.1 Fix list and location of installed header files
---------------------------------------+------------------------------------
 Reporter:  davidm@…                   |       Owner:  mmoll@…           
     Type:  defect                     |      Status:  new               
 Priority:  Normal                     |   Milestone:                    
Component:  ports                      |     Version:  1.8.2             
 Keywords:  haspatch                   |        Port:  qhull             
---------------------------------------+------------------------------------

Comment(by davidm@…):

 Seems good except that I think the headers should go in
 ${prefix}/include/qhull rather than just ${prefix}/include.  Many of them
 are very generically named (e.g. io.h, mem.h, etc.) so leaving them in
 ".../include" seems like asking for trouble (plus existing client code
 expects to include them via {{{#include <qhull/qhull_a.h>}}}).

 {{{
 $ port contents qhull | grep include
   /opt/local/include/geom.h
   /opt/local/include/io.h
   /opt/local/include/libqhull.h
   /opt/local/include/mem.h
   /opt/local/include/merge.h
   /opt/local/include/poly.h
   /opt/local/include/qhull.h
   /opt/local/include/qhull_a.h
   /opt/local/include/qset.h
   /opt/local/include/random.h
   /opt/local/include/stat.h
   /opt/local/include/user.h
 }}}
 A simple change to the last line of files/patch-src-CMakeLists.txt.diff
 (r63289) takes care of that...

 +install(FILES ${qhull_hdr} DESTINATION include/qhull)

 {{{
 $ port contents qhull | grep include
   /opt/local/include/qhull/geom.h
   /opt/local/include/qhull/io.h
   /opt/local/include/qhull/libqhull.h
   /opt/local/include/qhull/mem.h
   /opt/local/include/qhull/merge.h
   /opt/local/include/qhull/poly.h
   /opt/local/include/qhull/qhull.h
   /opt/local/include/qhull/qhull_a.h
   /opt/local/include/qhull/qset.h
   /opt/local/include/qhull/random.h
   /opt/local/include/qhull/stat.h
   /opt/local/include/qhull/user.h
 }}}

-- 
Ticket URL: <http://trac.macports.org/ticket/23420#comment:6>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list