[MacPorts] #25562: miriad 4.1.3.20100512 - update to version 4.1.3.20100706
MacPorts
noreply at macports.org
Mon Jul 12 01:08:10 PDT 2010
#25562: miriad 4.1.3.20100512 - update to version 4.1.3.20100706
---------------------------------+------------------------------------------
Reporter: peter@… | Owner: macports-tickets@…
Type: update | Status: new
Priority: Normal | Milestone:
Component: ports | Version: 1.9.1
Keywords: haspatch maintainer | Port: miriad
---------------------------------+------------------------------------------
Comment(by peter@…):
Replying to [comment:4 ryandesign@…]:
> There are two problems with this patch, and they're both the same
problem: you're specifying default variants even if the user has already
requested a conflicting other variant.
OK, thanks for committing an improved version.
In case you're interested in some context from a non-core Portfile author,
I had misunderstood what the default_variants directive did. Going from
guide.macports.org, I thought that it was a sort of global variable that
specified what variants would be used if the user didn't specify anything
on the commandline. Based on your change and a peek at portutil.tcl, my
understanding is that it's a directive that enables the specified variants
when executed in the portfile code. (I had wondered why the original
compiler-selection code was written the way it was; now that makes sense.)
I'd say that default_variants would be better named "enable_variants" or
something, but obviously there are backwards-compatibility issues related
to that.
--
Ticket URL: <http://trac.macports.org/ticket/25562#comment:6>
MacPorts <http://www.macports.org/>
Ports system for Mac OS
More information about the macports-tickets
mailing list