[MacPorts] #25562: miriad 4.1.3.20100512 - update to version 4.1.3.20100706
MacPorts
noreply at macports.org
Mon Jul 12 01:54:09 PDT 2010
#25562: miriad 4.1.3.20100512 - update to version 4.1.3.20100706
---------------------------------+------------------------------------------
Reporter: peter@… | Owner: macports-tickets@…
Type: update | Status: new
Priority: Normal | Milestone:
Component: ports | Version: 1.9.1
Keywords: haspatch maintainer | Port: miriad
---------------------------------+------------------------------------------
Comment(by ryandesign@…):
Replying to [comment:6 peter@…]:
> In case you're interested in some context from a non-core Portfile
author, I had misunderstood what the default_variants directive did. Going
from guide.macports.org, I thought that it was a sort of global variable
that specified what variants would be used if the user didn't specify
anything on the commandline. Based on your change and a peek at
portutil.tcl, my understanding is that it's a directive that enables the
specified variants when executed in the portfile code. (I had wondered why
the original compiler-selection code was written the way it was; now that
makes sense.) I'd say that default_variants would be better named
"enable_variants" or something, but obviously there are backwards-
compatibility issues related to that.
I initially (years ago) also misunderstood how `default_variants` works. I
have not looked at the base code for this, but I had assumed it was a
variable, like `configure.args` and most other portfile statements, and
that setting it would overwrite what was there before. After all, in order
to append to any other variable, you use the `-append` procedure (i.e.
"`configure.args-append`"). But no, just calling "`default_variants +foo`"
on its own causes the variant `+foo` to be appended to the list of default
variants. Its design is a bit strange compared to the rest of MacPorts.
Note that renaming it to "enable_variants" would not be ideal, because
with `default_variants` you can also disable variants. For example,
"`default_variants +x11 -universal`" enables the x11 variant by default
and disables the universal variant by default. Since all variants are
disabled anyway to start with, the only purpose for this that I see would
be to defeat variants a user might have specified in their variants.conf,
but I don't know why a port author would want to do such a thing. Note
that what's written in `default_variants` is only a default; the user is
still free to override those defaults at the command line (e.g. with
"`sudo port install someport -x11`"). We do also have the `variant_set`
and `variant_unset` procedures available, which the user cannot override
at the command line, but these have thus far not been used much in
portfiles.
[http://guide.macports.org/ The MacPorts Guide] could certainly use some
improvements to make this and other things clearer. Unlike the
Hitchhiker's Guide to the Galaxy, our Guide is unfortunately ''not''
definitive, not yet anyway. Patches for the documentation are appreciated.
--
Ticket URL: <http://trac.macports.org/ticket/25562#comment:8>
MacPorts <http://www.macports.org/>
Ports system for Mac OS
More information about the macports-tickets
mailing list